Note that the sketch on face stuff will have breaking changes in future, If you have access see: https://github.com/KittyCAD/engine/issues/1874

As we roll into features like SketchOnFace and fillets our ability to associate 3d features back to source code becomes much more important e.g. adding a tag in the correct place in the code so that we reference a face to sketch on or reference an edge to fillet. Because of this is was about time to give the selections some attention. Previous the way they were setup had a single code path for selecting either from the 3d scene, or placing your cursor directly in codemirror (because selections are just sourceRanges/cursor positions). The single code path seemed like a good idea since to made the code DRY, but it was dry spaghetti that callbacks spread all over the place

plus overhaul of selections

• All existing playwright tests (including selection tests ofc) pass again.
• Rotating the camera shouldn't nukes selections
• Close faces can't be selected properly (must not be added to artifact map?) (covered else where)
• start end caps should be selectable 663940a & 2e4206c
• id's that we the FE doesn't recognise (not in the artifactMap) should be cleared by default, and we should work to makes sure that entity get's into the artifact map. 93f7ff6
• sketch on face without z-up has some quirks to be worked through.
• start sketch on END of an extrude that had already been extruded from another parent uses the parent's extrude variable (2e4206c)
• close segments/faces should be selectable and sketchOnFace-able d3d148c
• clean up lastCodeMirrorSelectionUpdatedFromScene(646b5c2)
• add unit test for the extrusion codemod (9129f9a)
• selecting the "END" cap snaps to the "START" cap (15dbf2c)

optional

• Selecting a whole section of code should highlight many edges.
• maybe update sketchEnginePathId in xstate context
• I seem to have broken the sketch grid? (edit it's main so not related to this change)

Things to ask Josh about

-- edit, the chat Josh and I had resulted in this, we're going to keep chatting about it.

• Default origins for sketches,
• Camera movement on entering a sketch (related to Alignment of extrude walls below)

Things to bring up with Mike

• Figure out why highlight_set_entity events don't come through for edit mode, they highlight in the stream, but no websocket message come's through, check what I'm calling edit mode on.
• Why does edit work for all entities if I have to give it any single entity id?
• grid seems to change for edit mode (maybe related to the last point)
• Client doesn't recognise solid2d face (not in artifact map) figure out how to get it in there.
• Vertices should basically never be selectable, at least with the current features, maybe edit mode has an extra param that allows selection of things to be enable or not, so like edges, faces and vertices can all be turned on and off. This would solve the vertice problem as well as enable things like turning off edges as well when were waiting for the user to select a face to sketch on. Implement selection filter
• can't select pocket faces because solid3d_get_extrusion_face_info returns an empty array for these extrusions (side note that the original extend_path id get associated with the end of the extrusion, I thought it should probably be the start so as to sit on the face where it was sketched)
• behaviour of startSketchOn(part, 'START') seems to be different from "END" (not sure what to do about this)
• Let's talk about changing the behaviour of default plane selection to work better to clicking a object face through one of the default planes, and perhaps they transparency might need to be tweaked.
• Alignment of extrude walls seems to align best to world coords (makes for brittle models)
• https://github.com/KittyCAD/engine/issues/1860

Things to bring up with Jess

-- edit had a chat with Jess, edge ids on the sketch group should probably be done in collaboration with the grackle team since that migration is underway. Mock safe execution hacks are probably fine, I'll just leave a bunch of comments.

• Edge at the end of the extrusion are not selectable ( did try using "opposite edge" endpoint as the selection event comes through from the engine, it requires face_id an object_id, and the context I get from the engine is only the entity_id of the edge so I don't think it's possible)
• Edges parallel to the extrusion direction are not selectable (similar to the above)
• Talk to someone about execution being mock safe (extrude face ids are needed) basically changes in this file
• sketchGroup.on doesn't quiet have the info I need, have to rummage around to cobble it together (vague point probably covered by some of the above).